Attention is currently required from: Jérémy Compostella, NyeonWoo Kim, Paul Menzel.
Shuo Liu has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/86866?usp=email )
Change subject: arch/x86/postcar_loader: Add comment line for reloc_params assignment
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86866/comment/6c37f6e8_ff6d5fae?usp... :
PS7, Line 10: to be loaded as reloc_params, e.g. with its cache flushed.
Done
Seems that still has format issue. From logic point of view, LGTM. But please check with Paul for regulating the formats.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86866?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7d3f9cf514ce5a8efc2af9e78992cb39a91e537
Gerrit-Change-Number: 86866
Gerrit-PatchSet: 8
Gerrit-Owner: NyeonWoo Kim
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: NyeonWoo Kim
Gerrit-Comment-Date: Mon, 07 Apr 2025 05:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: NyeonWoo Kim