Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47038 )
Change subject: sb/intel/*/lpc.c: Don't try to write read-only PCICMD bits
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47038/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47038/2//COMMIT_MSG@9
PS2, Line 9: For all these southbridges, the lower nibble of PCICMD is read-only.
And for newer chips, the special bit is even supposed to be 0...
Anyway, was this tested? Sometimes datasheets can be deceiving and read-
only actually means read-only to the OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3b16b1b9651f7f3bd06ff8bc27dafd8a323e93c
Gerrit-Change-Number: 47038
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Nov 2020 20:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment