Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34877 )
Change subject: mb/google/kukui: Move panel description to CBFS files
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/...
PS7, Line 105: static u8 buffer[8 * 1024];
Sorry, why did all this revert to the old code again? I think you must have pushed from the wrong br […]
I was trying to edit with gerrit UI and I think I edited on wrong version. Fixed.
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/...
PS7, Line 138: }
Having the assert(panel->s) here could be useful if you're worried that one of the per-board impleme […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2560a11ecf7badfd0605ab189d57ec9456850f75
Gerrit-Change-Number: 34877
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Aug 2019 06:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment