Attention is currently required from: Furquan Shaikh, Marshall Dawson.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 )
Change subject: mb/google/guybrush: Update GPIO configuration
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/1b3c5c25_22fcff3f
PS7, Line 57: PAD_GPO
See my comment on b/182805349. […]
No, that's not the problem. The pin defaults to PAD_NF, so the initial tests were all done that way. We also explicitly set it to PAD_NF in the bootblock and had Compal test it. The pin never goes high unless we force it high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I512cb8b435dc8412cd46189e741ad94e5a24699e
Gerrit-Change-Number: 51675
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Sat, 27 Mar 2021 14:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment