build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44323 )
Change subject: cpu/x86/smm: Add a common save state handling
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44323/2/src/include/cpu/x86/save_st...
File src/include/cpu/x86/save_state.h:
https://review.coreboot.org/c/coreboot/+/44323/2/src/include/cpu/x86/save_st...
PS2, Line 22: int(*set_reg)(const enum cpu_reg reg, const int node, void *in, const uint8_t length);
missing space after return type
https://review.coreboot.org/c/coreboot/+/44323/2/src/include/cpu/x86/save_st...
PS2, Line 24: int(*apmc_node)(u8 cmd);
missing space after return type
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a31d05c09065543424a9010ac434dde0dfb5836
Gerrit-Change-Number: 44323
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 12:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment