Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45654 )
Change subject: soc/intel/cannonlake: Make CNL gpio_op.asl unified as TGL ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45654/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45654/1//COMMIT_MSG@9 PS1, Line 9: List
When you have a list of changes in a commit message, you should be suspicious: Shouldn't this be a l […]
Ack
https://review.coreboot.org/c/coreboot/+/45654/1/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/gpio_op.asl:
PS1:
I think the conversion to ASL 2.0 syntax can be done in its own commit. […]
Ack
https://review.coreboot.org/c/coreboot/+/45654/1/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/gpio_common.h:
PS1:
Dropping this in favor of common definitions is something best done in its own commit. […]
Ack
https://review.coreboot.org/c/coreboot/+/45654/1/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi/gpio_op.asl:
PS1:
Same here, the conversion to ASL 2.0 syntax would be best done in a separate commit.
Ack
https://review.coreboot.org/c/coreboot/+/45654/1/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45654/1/src/soc/intel/skylake/acpi/... PS1, Line 120: Local0 = PAD_CFG0_RX_STATE & (VAL0 >> PAD_CFG0_RX_STATE_BIT)
Same here, the conversion to ASL 2.0 syntax would be best done in a separate commit.
Ack