Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87301?usp=email )
Change subject: mb/google/nissa/var/dirks: correct usb2_ports setting ......................................................................
mb/google/nissa/var/dirks: correct usb2_ports setting
When re-purposing the TCSS port to USB Type-A, PortResetMessageEnable must be enabled for USB2 ports that are paired with the CPU XHCI port. Set to USB2_PORT_TYPE_C to enable PortResetMessageEnable. Also remove the workaround.
BUG=b:400809281 TEST=lsusb -t to check if the USB devices are enumerated correctly. Change-Id: I7c4743d1d3bcf2567fdca9c0e07ed02c240d4baf Signed-off-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/dirks/overridetree.cb 2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/87301/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 8886901..c27748a 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -1178,8 +1178,4 @@
If unsure, leave this option disabled.
-config D3COLD_SUPPORT - bool - default n if BOARD_GOOGLE_DIRKS - endif # BOARD_GOOGLE_BRYA_COMMON diff --git a/src/mainboard/google/brya/variants/dirks/overridetree.cb b/src/mainboard/google/brya/variants/dirks/overridetree.cb index 94c2457..4f7ed88 100644 --- a/src/mainboard/google/brya/variants/dirks/overridetree.cb +++ b/src/mainboard/google/brya/variants/dirks/overridetree.cb @@ -71,7 +71,7 @@ register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_A21, .pad_auxn_dc = GPP_A22}"
register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # USB2_C0 - register "usb2_ports[1]" = "USB2_PORT_MID(OC0)" # USB2_A0 + register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC0)" # USB2_A0 register "usb2_ports[2]" = "USB2_PORT_MID(OC1)" # USB2_A1 register "usb2_ports[3]" = "USB2_PORT_MID(OC2)" # USB2_A2 register "usb2_ports[4]" = "USB2_PORT_MID(OC3)" # USB2_A3