Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/intel/fsp2_0/Kc... PS2, Line 6: select MRC_SAVE_HASH_IN_TPM if HAS_RECOVERY_MRC_CACHE && TPM2
Does this need to have a select here? (The previous version also just used default y, not select, so […]
Removed.
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 54: VBOOT
Oh I guess you removed that in the next patch? I agree that I'm not sure why that restriction was th […]
No I didn't? Changed to VBOOT_STARTS_IN_BOOTBLOCK now though.
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 55: n
Probably do it only if CHROMEOS is selected? I don't think we want to change the default for any non […]
Agree we should default y the future boards. Changed to reflect that for ChromeOS boards.