Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36531 )
Change subject: soc/intel/icelake: Clean up report_cpu_info() function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36531/1/src/soc/intel/icelake/bootb...
File src/soc/intel/icelake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36531/1/src/soc/intel/icelake/bootb...
PS1, Line 119: /* Skip leading spaces in CPU name string */
: while (cpu_name[0] == ' ' && strlen(cpu_name) > 0)
: cpu_name++;
Nit: I think it would be clearer if this was placed in the if path.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c76eb93f0c5229c4a49aa041339b8ad51ad34a
Gerrit-Change-Number: 36531
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 10:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment