Attention is currently required from: Shelley Chen, Ravi kumar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55378 )
Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN
......................................................................
Patch Set 42:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131350):
https://review.coreboot.org/c/coreboot/+/55378/comment/eaaa9acd_d9ca41aa
PS42, Line 24: if (CONFIG(BOARD_GOOGLE_HEROBRINE)) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2
Gerrit-Change-Number: 55378
Gerrit-PatchSet: 42
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sandeep Maheswaram
sanm@codeaurora.org
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:27:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment