Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46395 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P driver ......................................................................
Patch Set 41:
(9 comments)
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/common/in... File src/soc/mediatek/common/include/soc/rtc_common.h:
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/common/in... PS41, Line 9: #include <soc/pmic_wrap_common.h> move to mt8183/include/soc/rtc.h ?
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/common/rt... File src/soc/mediatek/common/rtc.c:
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/common/rt... PS41, Line 144: if (con & RTC_CON_LPSTA_RAW) : return RTC_STATE_INIT; Does it effect 73/83 if the check is removed from common code ?
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8183/in... File src/soc/mediatek/mt8183/include/soc/rtc.h:
PS41: please also add change to mt8173/include/soc/rtc.h
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8183/in... PS41, Line 234: remove one blank
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/bo... File src/soc/mediatek/mt8192/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/bo... PS41, Line 10: #include <soc/rtc.h> in alphabet order
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/in... PS41, Line 6: #include <soc/rtc_common.h> : #include <soc/pmif.h> in alphabet order
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/in... PS41, Line 108: \ remove \
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/rt... File src/soc/mediatek/mt8192/rtc.c:
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/rt... PS41, Line 33: void static void ?
https://review.coreboot.org/c/coreboot/+/46395/41/src/soc/mediatek/mt8192/rt... PS41, Line 347: //rtc_write_field(PMIC_RG_DCXO_CW12, 0x0, 0x1, 0); remove