Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58552 )
Change subject: amdfwtool: Put soc name setting to fw.cfg from command line
......................................................................
Patch Set 7:
(2 comments)
File util/amdfwtool/data_parse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131292):
https://review.coreboot.org/c/coreboot/+/58552/comment/846476ec_74073513
PS7, Line 508: if (strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131292):
https://review.coreboot.org/c/coreboot/+/58552/comment/6f915b24_fb11e28a
PS7, Line 509: cb_config->soc_id = identify_platform(&(oneline[match[2].rm_so]));
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0eead1f2156542ea03d58145f5ad67683bf9b52
Gerrit-Change-Number: 58552
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 25 Oct 2021 02:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment