Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@7 PS2, Line 7: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting
I’d prefer a more specific commit message summary. Maybe split the commit up.
this is found by code review.
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@9 PS2, Line 9: Fix some programming errors.
Please elaborate.
this is found by code review.
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@13 PS2, Line 13: TEST=Boots correctly on Kukui
… as before, right? […]
no error before, this is found by code review.
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 894: (0x3 << 4) | (0x1 << 7) | (0x1 << 13),
Move to next line.
Done
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 952: (0x3 << 4) | (0x1 << 7) | (0x1 << 13),
Move to next line.
Done
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 51: size_t
u8
Done