Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39782 )
Change subject: mb/ocp/tiogapass: Properly configure early serial output
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39782/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39782/3//COMMIT_MSG@10
PS3, Line 10: currently we
I'd use "we currently"
https://review.coreboot.org/c/coreboot/+/39782/3//COMMIT_MSG@10
PS3, Line 10: As result
As *a* result
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff8e6a862858d733f529bb9b8c65e22e5ec6b521
Gerrit-Change-Number: 39782
Gerrit-PatchSet: 3
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment