Attention is currently required from: Jonathan Zhang.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72443 )
Change subject: soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/xeon_sp/spr/cpu.c:
https://review.coreboot.org/c/coreboot/+/72443/comment/6d685892_536959b8
PS13, Line 177: static const struct cpu_device_id cpu_table[] = {
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_D},
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E0},
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E2},
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E3},
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E4},
: {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_Ex},
: {0, 0},
: };
Good catch, thanks for helping on this Felix :)
Fix got submitted. Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2
Gerrit-Change-Number: 72443
Gerrit-PatchSet: 13
Gerrit-Owner: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Comment-Date: Wed, 03 May 2023 23:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment