24 Jan
2019
24 Jan
'19
2:49 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30585 )
Change subject: libgfxinit: Add options to limit framebuffer size ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30585/2/src/drivers/intel/gma/hires_fb/gma.a... File src/drivers/intel/gma/hires_fb/gma.adb:
https://review.coreboot.org/#/c/30585/2/src/drivers/intel/gma/hires_fb/gma.a... PS2, Line 67: LINEAR_FRAMEBUFFER_MAX_WIDTH I think CB.Config.LINEAR_FRAMEBUFFER_MAX_WIDTH is better documentation where the value comes from than use-ing it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47fba063629260c3a2854caf7a73f1a1e933d063
Gerrit-Change-Number: 30585
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 24 Jan 2019 13:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment