Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35349 )
Change subject: drivers/intel/fsp2_0: Allocate cfg_region_size for UPD
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35349/1/src/drivers/intel/fsp2_0/si...
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/35349/1/src/drivers/intel/fsp2_0/si...
PS1, Line 42: upd = xmalloc(hdr->cfg_region_size);
Add a check for cfg->region_region_size being > 0?
https://review.coreboot.org/c/coreboot/+/35349/1/src/drivers/intel/fsp2_0/si...
PS1, Line 45: image_size
cfg_region_size?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20fad0e27a2ad537898b6d01e5241e1508da690c
Gerrit-Change-Number: 35349
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 11 Sep 2019 20:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment