[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor SMBus base arguments

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42074 )

Change subject: soc/amd/common: Refactor SMBus base arguments
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s... 
File src/soc/amd/common/block/smbus/sm.c:

https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s... 
PS17, Line 28: 	res = find_resource(pbus->dev, 0x90);
> just had a look and that register is neither defined in the stoneyridge bkdg not in the picasso ppr. […]

AFAIR, I had a revert for the copy-paste of this file, but Marshall blocked it in Jan2020.

Revisit CB:29258. AFAICS pbus->dev is always the same PCI device so I don't understand how the resource could resolve to two different addresses. But if the register 0x90 was already broken since sb800 in 2011..