Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47235 )
Change subject: drivers/i2c/rx6110sa: Add basic ACPI support ......................................................................
Patch Set 7:
Patch Set 7:
Here is what I propose in this situation: We have already reached out to Seico Epson requesting a proper HID created by the manufacturer of the RTC. As soon as we get a reaction there, I will correct the HID here to match the one from Seico Epson with a patch. For now I do not see an urgent case to revert this patch as, as long there is no one using this ID in the kernel, it stays unused in the system. But at least we can test with this ID. Any objections from your side regarding this plan?
I would prefer to show explicitly that there is no HID assigned (current HID may give an impression that people are fine to use it). So, something like RX6110SA -> XXXX0000 will be good to do now. Otherwise no objections. (Of course you may switch over to PRP0001 which is legal use with DT properties and compatible string, but highly discouraged for market ready products)
OK, let me first get a feeling what Seico Epson can deliver and when. If it will turn out that we have a long run in front of us to get the right HID for the RTC, I will push a patch to change the HID to something different clearly stating that it is not ready for productive usage for now. If in turn there is a chance that we will get the needed HID soon (let's say within two weeks or so) I would like to wait for it. Does that sound reasonable?
Yes, I agree. Thank you! (Just to point out that as one of the last resort Siemens can allocate ID from their pool)
In order to avoid that this wrong HID will be part of our next release planned for the end of this week I have pushed a patch (https://review.coreboot.org/c/coreboot/+/47706) to temporarily omit the HID completely. Once we have a valid ID, I will change the code accordingly.