build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34932 )
Change subject: util/cbfstool: new utility pnortool ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor/pnor.h File util/cbfstool/pnor/pnor.h:
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor/pnor.h@9... PS1, Line 92: * @size: size of the fimware (bytes) 'fimware' may be misspelled - perhaps 'firmware'?
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor/pnor.h@1... PS1, Line 136: * returns a pointer to the entry in the pnor structure if successfull 'successfull' may be misspelled - perhaps 'successful'?
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor/pnor.c File util/cbfstool/pnor/pnor.c:
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor/pnor.c@1... PS1, Line 108: /* return 0; */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor_from_fmd... File util/cbfstool/pnor_from_fmd.c:
https://review.coreboot.org/c/coreboot/+/34932/1/util/cbfstool/pnor_from_fmd... PS1, Line 9: unsigned absolute_watermark) Prefer 'unsigned int' to bare use of 'unsigned'