Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45289/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45289/2//COMMIT_MSG@9 PS2, Line 9: Add support different ram id table base on board_id. Please describe the requirements in the commit message.
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: Rev revs
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: then than
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 123: cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; Please add braces around the else branch.
https://doc.coreboot.org/coding_style.html