Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 )
Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ......................................................................
Patch Set 18:
(1 comment)
File src/soc/amd/mendocino/root_complex.c:
https://review.coreboot.org/c/coreboot/+/68649/comment/8b9fa62d_e0822d2d PS16, Line 393: #else
Please don't resolve comments that are still open. […]
Hi Tim,
The current behavior is
#if (CONFIG(FEATURE_DYNAMIC_DPTC))
Line 269 /* Normal mode DPTC values. */ New struct dptc_input default_input = DPTC_INPUTS(new paras) /* Low/No Battery */ New struct dptc_input no_battery_input = DPTC_INPUTS(new paras) Line 303
#else
Line 394 /* Normal mode DPTC values. */ Old struct dptc_input default_input = DPTC_INPUTS(old paras) /* Low/No Battery */ Old struct dptc_input no_battery_input = DPTC_INPUTS(old paras) Line 415
#endif
Do you mean no matter FEATURE_DYNAMIC_DPTC enable/disable,
1. Use the New dptc_input no_battery_input = DPTC_INPUTS(new paras) 2. Use the New dptc_input default_input = DPTC_INPUTS(new paras)
I assume below behavior is your suggestion?
/* Normal mode DPTC values. */ New struct dptc_input default_input = DPTC_INPUTS(new paras) /* Low/No Battery */ New struct dptc_input no_battery_input = DPTC_INPUTS(new paras)
#if (CONFIG(FEATURE_DYNAMIC_DPTC))
Profile B to F
#endif
BR, Eric KY Cheng