Leo Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82701?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Add FW_CONFIG probe for WWAN devices ......................................................................
mb/google/nissa/var/pujjoga: Add FW_CONFIG probe for WWAN devices
Add FW_CONFIG probe based on pujjoga boxster of below devices: WWAN
BUG=b:336167281 TEST=Boot to OS and verify the WWAN devices is set based on fw_cofnig.
Change-Id: I94cb9ffe47888a8b7b5c6837ddfc390a1d2e77d1 Signed-off-by: Leo Chou leo.chou@lcfc.corp-partner.google.com --- M src/mainboard/google/brya/variants/pujjoga/Makefile.mk A src/mainboard/google/brya/variants/pujjoga/fw_config.c M src/mainboard/google/brya/variants/pujjoga/overridetree.cb 3 files changed, 51 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/82701/1
diff --git a/src/mainboard/google/brya/variants/pujjoga/Makefile.mk b/src/mainboard/google/brya/variants/pujjoga/Makefile.mk index d38141c..8ae0e3b 100644 --- a/src/mainboard/google/brya/variants/pujjoga/Makefile.mk +++ b/src/mainboard/google/brya/variants/pujjoga/Makefile.mk @@ -3,4 +3,5 @@
romstage-y += gpio.c
+ramstage-$(CONFIG_FW_CONFIG) += fw_config.c ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/pujjoga/fw_config.c b/src/mainboard/google/brya/variants/pujjoga/fw_config.c new file mode 100644 index 0000000..eaef2a2 --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjoga/fw_config.c @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <console/console.h> +#include <fw_config.h> + +static const struct pad_config wwan_disable_pads[] = { + /* A8 : WWAN_RF_DISABLE_ODL */ + PAD_NC(GPP_A8, NONE), + /* A12 : WWAN_PCIE_WAKE_ODL */ + PAD_NC(GPP_A12, NONE), + /* D5 : SRCCLKREQ0# ==> WWAN_CLKREQ_ODL */ + PAD_NC(GPP_D5, NONE), + /* D6 : WWAN_EN */ + PAD_NC(GPP_D6, NONE), + /* D15 : EN_PP2800_WCAM_X ==> WWAN_SAR_DETECT_2_ODL */ + PAD_NC(GPP_D15, NONE), + /* F12 : WWAN_RST_L */ + PAD_NC_LOCK(GPP_F12, NONE, LOCK_CONFIG), + /* H19 : SOC_I2C_SUB_INT_ODL */ + PAD_NC(GPP_H19, NONE), + /* H21 : WCAM_MCLK_R ==> WWAN_PERST_L */ + PAD_NC_LOCK(GPP_H21, NONE, LOCK_CONFIG), + /* H23 : WWAN_SAR_DETECT_ODL */ + PAD_NC(GPP_H23, NONE), +}; + +void fw_config_gpio_padbased_override(struct pad_config *padbased_table) +{ + if (fw_config_probe(FW_CONFIG(WWAN, WWAN_ABSENT))) { + printk(BIOS_INFO, "Disable WWAN-related GPIO pins.\n"); + gpio_padbased_override(padbased_table, wwan_disable_pads, + ARRAY_SIZE(wwan_disable_pads)); + } +} diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb index 5641b06..cd55c66 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb @@ -1,3 +1,11 @@ +fw_config + field WWAN 3 4 + option WWAN_ABSENT 0 + option LTE_PRESENT 1 + option 5G_PRESENT 2 + end +end + chip soc/intel/alderlake # Acoustic settings register "acoustic_noise_mitigation" = "1" @@ -298,7 +306,9 @@ chip drivers/usb/acpi register "desc" = ""USB2 WWAN"" register "type" = "UPC_TYPE_INTERNAL" - device ref usb2_port5 on end + device ref usb2_port2 on + probe WWAN LTE_PRESENT + end end chip drivers/usb/acpi register "desc" = ""USB2 UFC"" @@ -334,7 +344,9 @@ chip drivers/usb/acpi register "desc" = ""USB3 WWAN"" register "type" = "UPC_TYPE_INTERNAL" - device ref usb3_port3 on end + device ref usb3_port3 on + probe WWAN LTE_PRESENT + end end end end