Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34761 )
Change subject: soc/intel/common/gspi: Use GSPI bus id to map to the controller
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34761/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34761/3/src/soc/intel/common/block/...
PS3, Line 473: if (devfn < 0) {
: printk(BIOS_ERR, "%s: No GSPI controller found on SPI bus %u.\n",
: __func__, dev->bus);
: return -1;
: }
nit: Do we need the check here now? as gspi_ctrlr_params_init would already check for valid dev and devfn?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I792ab1fa6529f5317218896ad05321f8f17cedcd
Gerrit-Change-Number: 34761
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 14:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment