John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46571 )
Change subject: mb/google/volteer: Retrieve CBI about Retimer and notify TBT firmware
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/46571/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46571/4/src/mainboard/google/voltee...
PS4, Line 215: if (is_dev_enabled(dev)) {
braces {} are not necessary for single statement blocks
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bbad465dcab5b44b1ddbd6431391b5a3a18fa12
Gerrit-Change-Number: 46571
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Dec 2020 23:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment