Attention is currently required from: Christian Walter, Jason Nien, Jon Murphy, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78098?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: src/security/tpm: Enable Hibernate on setup failure
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78098/comment/d694e37f_da5f0a7d :
PS8, Line 7: src/
This slipped in again.
https://review.coreboot.org/c/coreboot/+/78098/comment/fdd21c51_5938c99d :
PS8, Line 11: GSC
Google Security Chip. It's our TPM that is used across ChromeBooks. […]
Thank you. It’s even `in Documentation/acronyms.md`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d9e8f75b25fb6c530a333024c342bea871eb85d
Gerrit-Change-Number: 78098
Gerrit-PatchSet: 8
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Sep 2023 05:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment