Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 225: if (res_base == res_limit)
Sure. I have uploaded the changes. Once those go through, I can update this.
Done
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 249: res->flags |= IORESOURCE_ASSIGNED;
As commented below, I think we should still set IORESOURCE_ASSIGNED. […]
Done
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 261: find_pci_tolm()
Done. Added check here: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 272: mark_resource_invalid(resource);
Okay. I think I understand what you are saying. […]
Dropped mark_resource_invalid().