Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62937 )
Change subject: makechips.sh: Clean up shellcheck errors and formatting ......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS2: I accidentally pushed this patch directly into the git repo after making the requested changes. Sorry about that. :-/
I can revert and submit it through gerrit again as a new patch if you'd like.
File makechips.sh:
https://review.coreboot.org/c/em100/+/62937/comment/a6714f16_c0b8f7ea PS1, Line 33: FILE
${FILE}?
Done
https://review.coreboot.org/c/em100/+/62937/comment/074182d4_ccc5193b PS1, Line 36: FILE
${FILE}?
Done
https://review.coreboot.org/c/em100/+/62937/comment/f8c479ff_8e825d0b PS1, Line 37: URL
${URL}? ${FILE}?
Done
https://review.coreboot.org/c/em100/+/62937/comment/df52c5c6_a8ede487 PS1, Line 40: FILE
${FILE} ?
Done
https://review.coreboot.org/c/em100/+/62937/comment/c582d2e7_0b522d14 PS1, Line 46: VERSION
should this be ${VERSION} ?
Done
https://review.coreboot.org/c/em100/+/62937/comment/2f35b192_55877361 PS1, Line 57: i
${i} ?
Done