Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42043 )
Change subject: util/amdfwtool: update to allow building in any location ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42043/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42043/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1182: uint8_t
bool?
Meh, Call me old, but I don't care to use bool. I really don't see the point. It's not like it's going to save memory or code soace. The smallest chunk of memory that can be addressed in a register is 8 bits. And it's either 0 or not zero.
Really, I think it should just be an int if anything, and let the compiler decide what to use.
Can you tell me what the advantage is to using bool (other than making it absolutely certain that it's either a 0 or 1 - and I don't really care here).
I mean, I'll change it if that's the new coreboot standard, but I think there are LOTS of places throughout the code that COULD use bool that don't.