Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39153 )
Change subject: soc/intel/tigerlake: configure ethernet
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39153/2/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39153/2/src/soc/intel/tigerlake/fsp...
PS2, Line 138: Lan
LAN
Ack
https://review.coreboot.org/c/coreboot/+/39153/2/src/soc/intel/tigerlake/fsp...
PS2, Line 143: params->PchLanEnable = dev->enabled;
Ternary operator?
pchLanEnable is based on device enable in devicetree.
if condition is error case when PCI dev is not defined and it's for non TGL soc case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3286f5fefc962a5e55b5554982271ed6b885f7d8
Gerrit-Change-Number: 39153
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:13:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment