[coreboot-gerrit] Change in coreboot[master]: mb/intel/harcuvar: Fix board_id() return type

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39015 )

Change subject: mb/intel/harcuvar: Fix board_id() return type
......................................................................

mb/intel/harcuvar: Fix board_id() return type

The weak definition of board_id() in coreboot_table.c returns a
uint32_t, so update this function to match. This fixes a compiler error
when using LTO.

Change-Id: I6ad03ecedcf4a4d9f0c917cdc760f81ddde06d11
Signed-off-by: Jacob Garber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39015
Tested-by: build bot (Jenkins) 
Reviewed-by: David Guckian
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M src/mainboard/intel/harcuvar/boardid.c
M src/mainboard/intel/harcuvar/harcuvar_boardid.h
M src/mainboard/intel/harcuvar/hsio.c
M src/mainboard/intel/harcuvar/romstage.c
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  HAOUAS Elyes: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  David Guckian: Looks good to me, but someone else must approve

diff --git a/src/mainboard/intel/harcuvar/boardid.c b/src/mainboard/intel/harcuvar/boardid.c
index 8f91b0c..a9d9af6 100644
--- a/src/mainboard/intel/harcuvar/boardid.c
+++ b/src/mainboard/intel/harcuvar/boardid.c
@@ -5,7 +5,7 @@

#include "harcuvar_boardid.h"

-uint8_t board_id(void)
+uint32_t board_id(void)
 {
    int id = BoardIdHarcuvar;

diff --git a/src/mainboard/intel/harcuvar/harcuvar_boardid.h b/src/mainboard/intel/harcuvar/harcuvar_boardid.h
index 28f28d9..cb05090 100644
--- a/src/mainboard/intel/harcuvar/harcuvar_boardid.h
+++ b/src/mainboard/intel/harcuvar/harcuvar_boardid.h
@@ -8,6 +8,6 @@

#define BoardIdHarcuvar 0x52

-uint8_t board_id(void);
+uint32_t board_id(void);

#endif /* MAINBOARD_BOARD_H */
diff --git a/src/mainboard/intel/harcuvar/hsio.c b/src/mainboard/intel/harcuvar/hsio.c
index d786b8f..948f326 100644
--- a/src/mainboard/intel/harcuvar/hsio.c
+++ b/src/mainboard/intel/harcuvar/hsio.c
@@ -7,7 +7,7 @@

size_t mainboard_get_hsio_config(BL_HSIO_INFORMATION **p_hsio_config)
 {
-    uint8_t boardid = board_id();
+    uint32_t boardid = board_id();
     size_t num;
     switch (boardid) {
     case BoardIdHarcuvar:
diff --git a/src/mainboard/intel/harcuvar/romstage.c b/src/mainboard/intel/harcuvar/romstage.c
index a5c1327..542f81e 100644
--- a/src/mainboard/intel/harcuvar/romstage.c
+++ b/src/mainboard/intel/harcuvar/romstage.c
@@ -88,7 +88,7 @@
 {
    size_t num;
    const struct dnv_pad_config *table;
-	uint8_t boardid = board_id();
+	uint32_t boardid = board_id();

/* Configure pads prior to SiliconInit() in case there's any
    * dependencies during hardware initialization.