Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42545 )
Change subject: soc/amd: move acpi_wake_source.asl to common directory
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42545/3/src/soc/amd/stoneyridge/acp...
File src/soc/amd/stoneyridge/acpi/acpi_wake_source.asl:
https://review.coreboot.org/c/coreboot/+/42545/3/src/soc/amd/stoneyridge/acp...
PS3, Line 17: GPEI
Is this defined in common as well?
That's defined in each SoC's globalnvs.asl which is different for stoneyridge and picasso
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54b78108d342a0fd03bf70ffe6a09695c5678eb4
Gerrit-Change-Number: 42545
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 16:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment