Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37247 )
Change subject: mb/google/octopus: Create Lick variant
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37247/9/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/lick/gpio.c:
https://review.coreboot.org/c/coreboot/+/37247/9/src/mainboard/google/octopu...
PS9, Line 25: sku1_default_override_table
Better to use default_override_table instead of sku1_default_override_table since this is the default table, sku1.* should be sku variant other than default one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If732d94194defb9f5ee9c847ee93dd58aef01174
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 9
Gerrit-Owner: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Regan Chang
regan.chang@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Nov 2019 06:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment