Attention is currently required from: Martin Roth, Akshu Agrawal, Matt Papageorge, Karthik Ramasubramanian.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52037 )
Change subject: acpi: Add support to generate upep structure
......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
File src/acpi/acpigen_upep.c:
https://review.coreboot.org/c/coreboot/+/52037/comment/dc906bca_17da2b38
PS1, Line 5:
Nit: extra line can be removed.
Done
https://review.coreboot.org/c/coreboot/+/52037/comment/318f0573_e150eed0
PS1, Line 7:
Nit: extra line can be removed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52037
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b64ddc9ebee251f3b50e81374c1b32cf5b1aeca
Gerrit-Change-Number: 52037
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 09 Apr 2021 14:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment