3 Jun
2019
3 Jun
'19
9:42 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33016 )
Change subject: src/driver/vpd: Update lib_vpd from upstream ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/33016/8/src/drivers/vpd/vpd_decode.c File src/drivers/vpd/vpd_decode.c:
https://review.coreboot.org/#/c/33016/8/src/drivers/vpd/vpd_decode.c@63 PS8, Line 63: *consumed + decoded_len + key_len >= max_len) I think this can overflow? You should cast to u64 to be safe.
https://review.coreboot.org/#/c/33016/8/src/drivers/vpd/vpd_decode.c@75 PS8, Line 75: *consumed + decoded_len + value_len > max_len) Same here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3928e9c43cb87caf93fb44ee10434ce80f0a188a
Gerrit-Change-Number: 33016
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment