Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35016 )
Change subject: arch/x86: Simplify <arch/early_variables.h>
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35016/5/src/lib/program.ld
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/35016/5/src/lib/program.ld@141
PS5, Line 141: #if ENV_STAGE_HAS_HEAP_SECTION && !ENV_CACHE_AS_RAM
nit: Isn't this one unnecessary?
If we did add .heap inside CAR, this becomes equally necessary as the .bss case above. Then again, for consistency STAGE_HAS_DATA should have this added too? We can go either way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9dc14f3e528d3e4f48304f4d7de50df448a8af6
Gerrit-Change-Number: 35016
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment