Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33559 )
Change subject: soc/intel/cannonlake/Kconfig: Don't have all variants select SOC_INTEL_CANNONLAKE
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33559/5/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33559/5/src/soc/intel/cannonlake/Kconfig@6
PS5, Line 6: default n
or `default y if SOC_INTEL_COMMON_CANNONLAKE_BASE && !SOC_INTEL_CANNONLAKE`
that would spare us some selects below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica11c68377e3d0dc8a8f48198e01a74d7bebe642
Gerrit-Change-Number: 33559
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 18 Jun 2019 12:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment