Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46391 )
Change subject: mb/google/asurada: Get RAM code from ADC 3 ......................................................................
Patch Set 22:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46391/22//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46391/22//COMMIT_MSG@11 PS22, Line 11: For Asurada the RAM code can be read from ADC channel 3. Can be merged to previous line. Be aware of the 72 line length limit.
https://review.coreboot.org/c/coreboot/+/46391/22/src/mainboard/google/asura... File src/mainboard/google/asurada/boardid.c:
https://review.coreboot.org/c/coreboot/+/46391/22/src/mainboard/google/asura... PS22, Line 18: /* 0 : */ 74300, Why not use
[0] = 74300,
https://review.coreboot.org/c/coreboot/+/46391/22/src/mainboard/google/asura... PS22, Line 41: int unsigned int
https://review.coreboot.org/c/coreboot/+/46391/22/src/mainboard/google/asura... PS22, Line 53: d u
https://review.coreboot.org/c/coreboot/+/46391/22/src/mainboard/google/asura... PS22, Line 53: d u