Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42784 )
Change subject: mb/amd/mandolin: factor out port descriptors from mainboard.c
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42784/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/42784/1/src/mainboard/amd/mandolin/...
PS1, Line 205: else {
eugh, how about placing the comment after the else to avoid that line break?
oh... yes, that's a good point; will fix
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2101cc0bae0d68cea1954424d18833aa22670c6
Gerrit-Change-Number: 42784
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 14:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment