Attention is currently required from: Raul Rangel, Jon Murphy, Martin Roth, Fred Reitberger, Tim Van Patten, Karthik Ramasubramanian, Felix Held, Mark Hasemeyer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 )
Change subject: mb/google/myst: Add new mainboard ......................................................................
Patch Set 9: Code-Review+2
(3 comments)
Patchset:
PS9: Its not perfect, but I think it's good enough of a base for the other patches to start landing. Pretty much everything in this patch still needs to be updated, so I'm completely unconcerned about anything here beyond the fact that it builds.
File src/mainboard/google/myst/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74093/comment/7c3eb59f_2fb3eab7 PS2, Line 2: SI_BIOS {
I'd have to check with the ABL team to know why the APOB increased.
For now, I think we just need to accept that the APOB has changed size again and see if we can fix that as the project goes along.
File src/mainboard/google/myst/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74093/comment/01488971_ce33e0e4 PS3, Line 36: }
A 16 MB layout for a first pass should be fine.
I'm fine with either 16 or 32, but RO needs to go at the bottom of the rom space. Phoenix will look for the EFS table at 0xff020000. For 16 vs 32MiB, we'll just have to see what fits. I'd be surprised if everything fits in 16MiB initially, but it would definitely be a good surprise.
I'd suggest we just go ahead and merge this as it is so that we can start working more on the myst platform instead of trying to get everything perfect on the first commit.