Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46818 )
Change subject: soc/intel/xeon_sp: Configure DPR on all stacks
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46818/5/src/soc/intel/xeon_sp/uncor...
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/46818/5/src/soc/intel/xeon_sp/uncor...
PS5, Line 320: configure_dpr(dev);
why not in init?
This should probably happen after clearing the memory has happened (BS_DEV_INIT, BS_ON_EXIT). If it is done in .final it also happens before LockConfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d34e50b3d577f19172619156352534f740ea6b
Gerrit-Change-Number: 46818
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment