Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30917 )
Change subject: soc/intel/cannonlake: Change in SaGv options
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30917/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30917/1//COMMIT_MSG@9
PS1, Line 9: CML
What does CML stand for?
Got it figured out, thanks for your explanation.
https://review.coreboot.org/#/c/30917/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30917/2//COMMIT_MSG@9
PS2, Line 9: CNL,WHL and CFL all are not using midfixed option in SaGv so keeping it for
: CNL only
Does CNL use the midfixed option or not?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754515c2f8e249479c603872c61ac9a006e962ff
Gerrit-Change-Number: 30917
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 14 Jan 2019 22:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment