Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44005 )
Change subject: drivers/generic/cbfs-serial: Update driver to read UUID from CBFS ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... File src/drivers/generic/cbfs-serial/cbfs-serial.c:
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 44: UUID_LENGTH Please use UUID_STRLEN from `uuid.h` instead. The length has to match exactly, otherwise it won't parse.
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 47: if (system_uuid[0] != 0) Nit, it could be 0 by coincidence. Also, I doubt this function is called more than once.
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 57: uuid_len <= UUID_LENGTH `uuid_len == sizeof(system_uuid) - 1` would make it most safe.
https://review.coreboot.org/c/coreboot/+/44005/1/src/drivers/generic/cbfs-se... PS1, Line 66: parse_uuid(uuid, system_uuid); This line seems quite redundant.