4 comments:
File src/drivers/generic/cbfs-serial/cbfs-serial.c:
Patch Set #1, Line 44: UUID_LENGTH
Please use UUID_STRLEN from `uuid.h` instead. The length has to match
exactly, otherwise it won't parse.
Patch Set #1, Line 47: if (system_uuid[0] != 0)
Nit, it could be 0 by coincidence. Also, I doubt this function is called
more than once.
Patch Set #1, Line 57: uuid_len <= UUID_LENGTH
`uuid_len == sizeof(system_uuid) - 1` would make it most safe.
Patch Set #1, Line 66: parse_uuid(uuid, system_uuid);
This line seems quite redundant.
To view, visit change 44005. To unsubscribe, or for help writing mail filters, visit settings.