2 Oct
2018
2 Oct
'18
9:37 p.m.
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28878 )
Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ......................................................................
Patch Set 3:
Using #if is a bad habit. Also, what are the outer parentheses for?
If I'm not wrong, '#if' is used in (romstage) to bypass the code if the statement is not true.
--
To view, visit https://review.coreboot.org/28878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0
Gerrit-Change-Number: 28878
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Oct 2018 19:37:14 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No