[coreboot-gerrit] Change in ...coreboot[master]: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )

Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c 
File src/lib/coreboot_table.c:

https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c@288 
PS1, Line 288: 	if (find_fmap_directory(&fmrd) == 0)
> true, but I don't know the size. […]

I'm confused... where are you mmaping the FMAP? Not in this code, right? Or am I missing something?

If the payload wants to use this to read the FMAP, it should follow the same approach (first find out size, then read all entries). I mean, that's what calling find_fmap_directory() here does anyway. It doesn't make sense to spend more time re-reading the FMAP here just so that a payload might potentially spend less time reading it later.