1 comment:
File src/lib/coreboot_table.c:
Patch Set #1, Line 288: if (find_fmap_directory(&fmrd) == 0)
true, but I don't know the size. […]
I'm confused... where are you mmaping the FMAP? Not in this code, right? Or am I missing something?
If the payload wants to use this to read the FMAP, it should follow the same approach (first find out size, then read all entries). I mean, that's what calling find_fmap_directory() here does anyway. It doesn't make sense to spend more time re-reading the FMAP here just so that a payload might potentially spend less time reading it later.
To view, visit change 33107. To unsubscribe, or for help writing mail filters, visit settings.