Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38478 )
Change subject: soc/intel/skylake: Clean up systemagent.asl code
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38478/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38478/1//COMMIT_MSG@11
PS1, Line 11: 2. Update 64 bit SA DRAM bit fields as per SKL EDS.
That’s not a clean-up in my opinion.
i will get back on this
https://review.coreboot.org/c/coreboot/+/38478/1//COMMIT_MSG@14
PS1, Line 14: 5. Reserve TPM area as applicable.
Please split this commit into smaller pieces. Maybe one for each item.
sure let me get back
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ce4866a83df40c38b69b07a71db3b81bca3981
Gerrit-Change-Number: 38478
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Jan 2020 09:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment