[coreboot-gerrit] Change in coreboot[master]: [WIP]Allow to build romstage sources inside the bootblock

[Arthur Heymans (Code Review)]

Attention is currently required from: Raul Rangel, Furquan Shaikh, Philipp Hug, ron minnich, Angel Pons, Subrata Banik, Julius Werner, Andrey Petrov, Aaron Durbin, Patrick Rudolph, Piotr Król, Jason Glenesk, Michał Żygowski, Martin Roth, Marshall Dawson, Ron Minnich, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55068 )

Change subject: [WIP]Allow to build romstage sources inside the bootblock
......................................................................

Patch Set 1:

(3 comments)

File src/drivers/amd/agesa/def_callouts.c:

https://review.coreboot.org/c/coreboot/+/55068/comment/7782f079_52671ba7 
PS1, Line 132: 	if (!(ENV_ROMSTAGE || (ENV_BOOTBLOCK && !CONFIG(SEPARATE_ROMSTAGE)))
> Would defining both `ENV_BOOTBLOCK` and `ENV_ROMSTAGE` for the combined stage work? Or does existing code rely on the assumption that they're mutually exclusive?

I thought the linker scripts would disagree but that was easy to fix :-)

File src/lib/prog_loaders.c:

https://review.coreboot.org/c/coreboot/+/55068/comment/69bf7d5d_d6114b82 
PS1, Line 19: #include <romstage_common.h>
> x86-specific, apparently.

Hence the WIP

File src/southbridge/intel/bd82x6x/early_pch.c:

https://review.coreboot.org/c/coreboot/+/55068/comment/193612e0_ec861e55 
PS1, Line 313: 	if (ENV_ROMSTAGE || (ENV_BOOTBLOCK && !CONFIG(SEPARATE_ROMSTAGE)))
> This guard exists because this function is called twice: once in bootblock, once in romstage. I had some patches to clean it up, but they're probably stale by now...
>
> src/southbridge/intel/bd82x6x/bootblock.c:	early_pch_init();
>  src/northbridge/intel/sandybridge/romstage.c:	early_pch_init();

Yeah that needs to be fixed. That was done for some weird compatibility reasons but there is no need for that anymore.