Attention is currently required from: Eric Lai, Julius Werner, Paul Menzel, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77635?usp=email )
Change subject: libpayload/vboot: Add vboot context initialization and management code ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77635/comment/9906f725_4e328601 : PS2, Line 8:
Please add a motivation for this change.
Done
https://review.coreboot.org/c/coreboot/+/77635/comment/dd4bdb9d_0fa8b8d1 : PS2, Line 11: crrev.com/c/4839296
A proper URL would allow readers to just click it. […]
Done
File payloads/libpayload/vboot/commonparams.c:
https://review.coreboot.org/c/coreboot/+/77635/comment/786eb77f_132aef66 : PS2, Line 3: #include <libpayload-config.h>
nit: reorder the headers.
`libpayload-config.h` is an exception to the rule of alphabetical order of headers and has to be on top.
You can easily see that all other files follow this exceptional rule: `$ grep -rIn3e 'libpayload-config.h' payloads/libpayload`